Skip to content

Conversation

@iamdin
Copy link
Member

@iamdin iamdin commented Sep 1, 2025

Summary

  • Comment out email subscription functionality in newsletter and CTA components as it's not implemented yet
  • Temporarily disables the email subscribe forms until proper backend implementation is ready

Test plan

  • Verify the landing page loads without email subscribe sections
  • Confirm no JavaScript errors in browser console
  • Check that the layout still looks proper with commented sections

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Temporarily disabled the “Stay Updated” newsletter signup on the landing page. The heading, description, email field, and Subscribe button are no longer displayed.
    • The newsletter call-to-action is hidden across the landing experience to prevent subscription attempts.
    • No other user-facing sections are impacted; general page content and navigation remain unchanged.

Comment out email subscription functionality in newsletter and CTA components as it's not implemented yet.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2025

⚠️ No Changeset found

Latest commit: 0959437

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Sep 1, 2025

Walkthrough

The newsletter-related UI in two landing components was commented out. Both cta.astro and newsletter.astro now wrap their newsletter markup in HTML comments, preventing rendering. No exports or public APIs were changed.

Changes

Cohort / File(s) Summary
Newsletter UI disabled
apps/www/src/components/landing/cta.astro, apps/www/src/components/landing/newsletter.astro
Wrapped newsletter sections in HTML comments, disabling rendering of headings, descriptions, inputs, and buttons without changing any exports or public interfaces.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant LandingPage
  participant CTAComponent as CTA (.astro)
  participant Newsletter as Newsletter (.astro)

  User->>LandingPage: Request page
  LandingPage->>CTAComponent: Render CTA
  alt Previous behavior
    CTAComponent->>Newsletter: Render newsletter section
    Newsletter-->>CTAComponent: Newsletter markup rendered
  else Current behavior
    note right of CTAComponent: Newsletter block is commented out
    CTAComponent-->>LandingPage: Skip newsletter rendering
  end
  LandingPage-->>User: Response without newsletter UI
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I twitch my whiskers, snip-snap, snare—
The newsletter sleeps in commented air.
Buttons hush, inputs lie still,
HTML dreams on the window sill.
I’ll hop back later, code in paw—
To wake the words with a gentle gnaw. 🐇✨

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor-email-subscribe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/www/src/components/landing/cta.astro (1)

108-122: Replace HTML comments with a feature-flagged conditional render

Commenting ships the whole block as HTML comments to clients and leaks copy into page source. Gate-render it instead; cleaner and easier to re-enable.

-  <!-- Stay Updated Newsletter Section - commented out for now, not implemented yet
+  {showSubscribe && (
   <div class="mt-12">
     <form class="flex items-center justify-center gap-2">
       <Input
         type="email"
         placeholder="Stay updated - enter your email"
         className="max-w-xs"
         required
       />
       <Button size="sm" type="submit" className="rounded-xs">
         Subscribe
       </Button>
     </form>
   </div>
-  -->
+  )}

Add in frontmatter:

// feature flag; consider centralizing in siteConfig.features.newsletter
const showSubscribe = false
apps/www/src/components/landing/newsletter.astro (1)

6-28: Gate newsletter sections with a feature flag instead of HTML comments

  • In apps/www/src/components/landing/newsletter.astro and apps/www/src/components/landing/cta.astro, replace the commented-out newsletter blocks with conditional rendering:
    {showNewsletter && (
      <!-- newsletter markup here -->
    )}
  • In each component’s frontmatter (or at a higher level), introduce the flag—e.g.:
    // ideally driven from siteConfig.features.newsletter
    const showNewsletter = siteConfig.features.newsletter ?? false
  • Ensure there are no remaining commented-out subscribe sections in your .astro files.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0fdfba7 and 0959437.

📒 Files selected for processing (2)
  • apps/www/src/components/landing/cta.astro (2 hunks)
  • apps/www/src/components/landing/newsletter.astro (2 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
apps/www/**/*

📄 CodeRabbit inference engine (.cursor/rules/overview.mdc)

Document all components and features in the documentation website (apps/www/)

Files:

  • apps/www/src/components/landing/cta.astro
  • apps/www/src/components/landing/newsletter.astro
apps/www/src/**

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

The main documentation website source code must be located under apps/www/src/

Files:

  • apps/www/src/components/landing/cta.astro
  • apps/www/src/components/landing/newsletter.astro
apps/www/**

📄 CodeRabbit inference engine (AGENTS.md)

Host the documentation site code in apps/www (Astro/MDX/Tailwind v4)

Files:

  • apps/www/src/components/landing/cta.astro
  • apps/www/src/components/landing/newsletter.astro

@iamdin iamdin merged commit a2b9745 into next Sep 1, 2025
3 of 4 checks passed
@iamdin iamdin deleted the refactor-email-subscribe branch September 1, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants