Don't replace commented DB_HOST on my .env#117
Open
yh1224 wants to merge 1 commit intoshipping-docker:masterfrom
yh1224:patch-1
Open
Don't replace commented DB_HOST on my .env#117yh1224 wants to merge 1 commit intoshipping-docker:masterfrom yh1224:patch-1
yh1224 wants to merge 1 commit intoshipping-docker:masterfrom
yh1224:patch-1
Conversation
Contributor
|
I think this creates a backup of your .env file before changing it - is that not the case for you? (It might depend on if you're on MacOS or not, due to how In any case, sorry about that! Can you confirm: Does this change only swap out the first instance of |
Author
|
@fideloper sorry for late reply. Yes, I can recover from .bak file, so It's not too much problem. Applying to this batch to original .env like below: BEFORE AFTER
It swap out all lines of active DB_HOST (if exists multiple) as before. |
Jamesking56
approved these changes
Jan 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I lost my commented line for alternative DB host :-(
I think it's better to replace active DB_HOST line only.