chore(deps): upgrade Ubuntu 20.04 by vinayakkulkarni · Pull Request #143 · shipping-docker/vessel

vinayakkulkarni · 2020-04-26T20:09:01Z

upgrade Ubuntu LTS version

fideloper · 2020-04-26T20:14:50Z

Hi! This doesn’t take into account any of the packages that install assuming this is Ubuntu 18.04 (bionic). The nginx/PHP repositories used don’t yet have builds for 20.04 so this wouldn’t build successfully.

…

On Sun, Apr 26, 2020 at 15:09 Vinayak Kulkarni ***@***.***> wrote: - upgrade Ubuntu LTS version ------------------------------ You can view, comment on, or merge this pull request online at: #143 Commit Summary - chore: upgrade Ubuntu 20.04 File Changes - *M* docker-files/docker/app/Dockerfile <https://github.com/shipping-docker/vessel/pull/143/files#diff-e4cc6ce63d9b8a9a4adbe95d927542ab> (2) Patch Links: - https://github.com/shipping-docker/vessel/pull/143.patch - https://github.com/shipping-docker/vessel/pull/143.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#143>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSDU7FGX2TJQTZN2AVFZLROSIGTANCNFSM4MRMKKWA> .

fideloper · 2020-04-26T20:22:25Z

Specifically these:

https://github.com/shipping-docker/vessel/blob/master/docker-files/docker/app/Dockerfile#L17-L18

The change will be bionic -> focal when those repositories have builds for 20.04.

So, we'll need to wait a bit for those to get updated! Then we can merge in your PR after updating bionic -> focal and giving it a test.

Thanks!

vinayakkulkarni · 2020-04-26T21:13:46Z

I've updated the reference of php & nginx repos to point to focal (20.04) instead of bionic (18.04)

fideloper · 2020-04-26T21:15:11Z

Appreciate it! When those repositories finally update with the packages for 20.04 we can test this out and merge it 👍🏻👍🏻

…

On Sun, Apr 26, 2020 at 16:13 Vinayak Kulkarni ***@***.***> wrote: I've updated the reference of php & nginx repos to point to focal (20.04) instead of bionic (18.04) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSDU3ERAM5GTGBUZA5MO3ROSPZNANCNFSM4MRMKKWA> .

vinayakkulkarni · 2020-04-27T12:22:59Z

Appreciate it! When those repositories finally update with the packages for 20.04 we can test this out and merge it 👍🏻👍🏻
…
On Sun, Apr 26, 2020 at 16:13 Vinayak Kulkarni @.***> wrote: I've updated the reference of php & nginx repos to point to focal (20.04) instead of bionic (18.04) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADSDU3ERAM5GTGBUZA5MO3ROSPZNANCNFSM4MRMKKWA .

PHP has already deps for focal, waiting for nginx focal to be added

Ticket in nginx : https://trac.nginx.org/nginx/ticket/1955

vinayakkulkarni · 2020-04-27T12:31:29Z

Oh btw, #131 would've ran this automatically instead of me manually sending a PR

vinayakkulkarni · 2020-05-12T18:07:57Z

I think we should use the official nginx ppa instead of launchpad ppa..

fideloper · 2020-05-12T18:11:57Z

Launchpad is where PPA's are hosted - the one used is the official one built by Nginx.

fideloper · 2020-05-12T18:12:36Z

Looks like PHP for Focal might be ready finally, so we may be ready to try this out! 👌

vinayakkulkarni · 2020-05-12T18:14:01Z

Launchpad is where PPA's are hosted - the one used is the official one built by Nginx.

http://nginx.org/en/linux_packages.html#Ubuntu

fideloper · 2020-05-12T20:04:48Z

Ah thanks, I see actually on another page they say they aren't maintaining the PPA from launchpad. I'll check on that too. Appreciate it!

…

On Tue, May 12, 2020 at 1:14 PM Vinayak Kulkarni ***@***.***> wrote: Launchpad is where PPA's are hosted - the one used is the official one built by Nginx. http://nginx.org/en/linux_packages.html#Ubuntu — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSDU5BFOILGWRV5CJNSULRRGGXRANCNFSM4MRMKKWA> .

vinayakkulkarni · 2020-05-13T02:55:04Z

If you want, I can setup config for using the official nginx ppa instead of launchpad one in this PR?

Or shall I send a new PR for bionic, then rebase this PR and just do incremental change for focal?

fideloper · 2020-05-13T19:41:34Z

Adding to this PR would be fine, thanks! Once that's setup we can run some tests (require `dev-master` into a laravel project and try it out. We can edit the local `docker-compose.yml` file to name the resulting image something other than the stock name, which will tell docker-compose to build the image even if you already have a vessel app image created locally).

…

On Tue, May 12, 2020 at 9:55 PM Vinayak Kulkarni ***@***.***> wrote: If you want, I can setup config for using the official nginx ppa instead of launchpad one in this PR? Or shall I send a new PR for bionic, then rebase this PR and just do incremental change for focal? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#143 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADSDU5LGXSG7Q72PRILABDRRIDZJANCNFSM4MRMKKWA> .

fideloper · 2020-05-19T20:19:29Z

I played with installing Nginx via their official repo recently - They use a different configuration file structure.

Specifically /etc/nginx/sites-enabled isn't used, it instead wants config files in /etc/nginx/conf.d.

Change to be made: https://github.com/shipping-docker/vessel/blob/master/docker-files/docker/app/Dockerfile#L46

(just making notes here, I got some work stuff keeping me busy right now)

fideloper · 2020-05-21T02:55:22Z

(also the fastcgj parameters aren’t all set!) So that’s need to be back filled.
I think that’s it. I personally replaced most nginx config with H5BP’s nginx config when I tested on an AWS server recently.

vinayakkulkarni · 2020-05-21T04:19:24Z

Awesome!

vinayakkulkarni · 2020-05-21T04:25:36Z

You're free to add commits in this branch.
I am buried in work for the next few days :(

fideloper · 2020-05-21T12:08:06Z

My plan right now (when I get some free time also :D )

Adjust scripts to add the default config to the /etc/nginx/conf.d directory
Add/replace the default config with H5BP's config (likely will pin to a specific release/hash)
Grab the proxy params from the PPA-installed setup to reproduce within the Nginx config

Here is the setup for fastcgi settings currently (to reproduce):

File /etc/nginx/snippets/fastcgi-php.conf:

# regex to split $uri to $fastcgi_script_name and $fastcgi_path
fastcgi_split_path_info ^(.+\.php)(/.+)$;

# Check that the PHP script exists before passing it
try_files $fastcgi_script_name =404;

# Bypass the fact that try_files resets $fastcgi_path_info
# see: http://trac.nginx.org/nginx/ticket/321
set $path_info $fastcgi_path_info;
fastcgi_param PATH_INFO $path_info;

fastcgi_index index.php;
include fastcgi.conf;

File /etc/nginx/fastcgi.conf:

fastcgi_param  SCRIPT_FILENAME    $document_root$fastcgi_script_name;
fastcgi_param  QUERY_STRING       $query_string;
fastcgi_param  REQUEST_METHOD     $request_method;
fastcgi_param  CONTENT_TYPE       $content_type;
fastcgi_param  CONTENT_LENGTH     $content_length;

fastcgi_param  SCRIPT_NAME        $fastcgi_script_name;
fastcgi_param  REQUEST_URI        $request_uri;
fastcgi_param  DOCUMENT_URI       $document_uri;
fastcgi_param  DOCUMENT_ROOT      $document_root;
fastcgi_param  SERVER_PROTOCOL    $server_protocol;
fastcgi_param  REQUEST_SCHEME     $scheme;
fastcgi_param  HTTPS              $https if_not_empty;

fastcgi_param  GATEWAY_INTERFACE  CGI/1.1;
fastcgi_param  SERVER_SOFTWARE    nginx/$nginx_version;

fastcgi_param  REMOTE_ADDR        $remote_addr;
fastcgi_param  REMOTE_PORT        $remote_port;
fastcgi_param  SERVER_ADDR        $server_addr;
fastcgi_param  SERVER_PORT        $server_port;
fastcgi_param  SERVER_NAME        $server_name;

# PHP only, required if PHP was built with --enable-force-cgi-redirect
fastcgi_param  REDIRECT_STATUS    200;

The default file fastcgi_params exists in BOTH install locations but does NOT contain fastcgi_param SCRIPT_FILENAME $document_root$fastcgi_script_name;, which is needed.

In our case we can likely just create a single file fastcgi-php.conf in /etc/nginx with the combined output:

# regex to split $uri to $fastcgi_script_name and $fastcgi_path
fastcgi_split_path_info ^(.+\.php)(/.+)$;

# Check that the PHP script exists before passing it
try_files $fastcgi_script_name =404;

# Bypass the fact that try_files resets $fastcgi_path_info
# see: http://trac.nginx.org/nginx/ticket/321
set $path_info $fastcgi_path_info;
fastcgi_param PATH_INFO $path_info;

fastcgi_index index.php;

fastcgi_param  SCRIPT_FILENAME    $document_root$fastcgi_script_name;
fastcgi_param  QUERY_STRING       $query_string;
fastcgi_param  REQUEST_METHOD     $request_method;
fastcgi_param  CONTENT_TYPE       $content_type;
fastcgi_param  CONTENT_LENGTH     $content_length;

fastcgi_param  SCRIPT_NAME        $fastcgi_script_name;
fastcgi_param  REQUEST_URI        $request_uri;
fastcgi_param  DOCUMENT_URI       $document_uri;
fastcgi_param  DOCUMENT_ROOT      $document_root;
fastcgi_param  SERVER_PROTOCOL    $server_protocol;
fastcgi_param  REQUEST_SCHEME     $scheme;
fastcgi_param  HTTPS              $https if_not_empty;

fastcgi_param  GATEWAY_INTERFACE  CGI/1.1;
fastcgi_param  SERVER_SOFTWARE    nginx/$nginx_version;

fastcgi_param  REMOTE_ADDR        $remote_addr;
fastcgi_param  REMOTE_PORT        $remote_port;
fastcgi_param  SERVER_ADDR        $server_addr;
fastcgi_param  SERVER_PORT        $server_port;
fastcgi_param  SERVER_NAME        $server_name;

# PHP only, required if PHP was built with --enable-force-cgi-redirect
fastcgi_param  REDIRECT_STATUS    200;

vinayakkulkarni · 2020-08-04T10:11:35Z

@fideloper : i'll be working on this over the next few days

fideloper · 2020-10-15T14:36:35Z

Merged via #147

chore: upgrade Ubuntu 20.04

5cfd158

chore: update nginx & php repo links

ad0bc63

vinayakkulkarni added 2 commits May 20, 2020 01:02

feat: use nginx ppa instead of launchpad

f9447d4

chore: update ordering for better readability

46cbf47

fideloper mentioned this pull request Oct 15, 2020

Vinayakkulkarni chore/upgrade ubuntu #147

Merged

fideloper merged commit 1651d98 into shipping-docker:master Oct 15, 2020

Conversation

vinayakkulkarni commented Apr 26, 2020

Uh oh!

fideloper commented Apr 26, 2020 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fideloper commented Apr 26, 2020

Uh oh!

vinayakkulkarni commented Apr 26, 2020

Uh oh!

fideloper commented Apr 26, 2020 via email

Uh oh!

vinayakkulkarni commented Apr 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinayakkulkarni commented Apr 27, 2020

Uh oh!

vinayakkulkarni commented May 12, 2020

Uh oh!

fideloper commented May 12, 2020

Uh oh!

fideloper commented May 12, 2020

Uh oh!

vinayakkulkarni commented May 12, 2020

Uh oh!

fideloper commented May 12, 2020 via email

Uh oh!

vinayakkulkarni commented May 13, 2020

Uh oh!

fideloper commented May 13, 2020 via email

Uh oh!

fideloper commented May 19, 2020

Uh oh!

fideloper commented May 21, 2020

Uh oh!

vinayakkulkarni commented May 21, 2020

Uh oh!

vinayakkulkarni commented May 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fideloper commented May 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vinayakkulkarni commented Aug 4, 2020

Uh oh!

fideloper commented Oct 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fideloper commented Apr 26, 2020 via email •

edited

Loading

vinayakkulkarni commented Apr 27, 2020 •

edited

Loading

vinayakkulkarni commented May 21, 2020 •

edited

Loading

fideloper commented May 21, 2020 •

edited

Loading