Skip to content

Fix incomplete error handling in createZip stream pipeline #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madebydavid merged 3 commits into from
Jan 22, 2026
Merged

Fix incomplete error handling in createZip stream pipeline #146

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f06929
Initial plan
Copilot Jan 22, 2026
dfc6424
Improve error handling in createZip function
Copilot Jan 22, 2026
76277cb
Add zipFile.outputStream cleanup to prevent resource leaks
Copilot Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions src/utils/zip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,26 @@ export async function createZip({files, outputPath, onProgress}: CreateZipProps)
}

return new Promise<void>((resolve, reject) => {
let settled = false

const handleError = (error: Error) => {
if (settled) return
settled = true

// Clean up streams
zipFile.outputStream.destroy()
progressStream.destroy()
outputStream.destroy()

reject(error)
}

const handleSuccess = () => {
if (settled) return
settled = true
resolve()
}

const outputStream = fs.createWriteStream(outputPath)

const progressStream = createProgressStream(estimatedZipSize, (written, total) => {
Expand All @@ -66,11 +86,15 @@ export async function createZip({files, outputPath, onProgress}: CreateZipProps)
})
}, ON_PROGRESS_THROTTLE_MS)

// Add error handlers to all streams in the pipe chain
zipFile.outputStream.on('error', handleError)
progressStream.on('error', handleError)
outputStream.on('error', handleError)
outputStream.on('close', handleSuccess)

zipFile.outputStream
.pipe(progressStream)
.pipe(outputStream)
.on('close', () => resolve())
.on('error', reject)

zipFile.end()
})
Expand Down