Adds support for instance attribute and custom attributes#11
Open
Axeltherabbit wants to merge 5 commits intoshivanshs9:masterfrom
Open
Adds support for instance attribute and custom attributes#11Axeltherabbit wants to merge 5 commits intoshivanshs9:masterfrom
Axeltherabbit wants to merge 5 commits intoshivanshs9:masterfrom
Conversation
shivanshs9
requested changes
Nov 9, 2022
Owner
shivanshs9
left a comment
shivanshs9
left a comment
There was a problem hiding this comment.
Thanks for the PR, suggested some small improvements.
drf_problems/exceptions.py
Outdated
| data['type'] = problem_type | ||
| if problem_instance: | ||
| data['instance'] = problem_instance | ||
| data.update(problem_extensions) |
Owner
There was a problem hiding this comment.
problem_extensions should be dict so please do a type check here
Author
|
Are the changes fine? Can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I mentioned here #10 I wasn't sure if there was already a way to do this, if there was never mind I guess.
example: