Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
## Goal
Set up SSH commit signing and add a PR template for Lab 1.

## Changes
- Configured SSH commit signing in git.
- Added minimal pull request template at `.github/pull_request_template.md`.
- Created `labs/submission1.md` with answers and screenshots.

## Testing
- Created a signed commit, checked that it is marked "Verified" on GitHub.
- Opened a new pull request and confirmed that the template appears automatically.

## Checklist
- [x] Clear, descriptive PR title
- [x] Documentation/README updated if needed
- [x] No secrets or large temporary files committed

Binary file added labs/screenshots/pr_template_autofill.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added labs/screenshots/verified_commit.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
26 changes: 26 additions & 0 deletions labs/submission1.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,29 @@ user.signingkey=/Users/shiyanovn/.ssh/id_ed25519.pub
### 3. Why is Commit Signing Important in DevOps Workflows?

In DevOps, many people work on the same code. Signed commits help us know exactly who made each change. It stops attackers or mistakes from unknown people, and is required for security in many companies.


---

[My signed commit](https://github.com/shiyanovn/DevOps-Intro/commit/d3059b65be7140413647905435e988f4705540a0)

![Verified commit screenshot](screenshots/verified_commit.png)
---

## Task 2: PR Template & Checklist

### 1. PR Template Location

File `.github/pull_request_template.md` is created in the main branch.

### 2. Screenshot of PR Template Auto-fill

![PR template autofill screenshot](screenshots/pr_template_autofill.png)

### 3. How PR Templates Help

PR templates help teams to remember all important information for every pull request. It makes review easier and reduces mistakes.

### 4. Challenges

At first, the template did not appear because I created PR before adding the file to main. I learned the template must be in main before PR.