Add explicit dependency between shop-pddl-tests and warns-check.lisp #139
Conversation
By moving warns-check.lisp into the shop-test-helper component, then adding a depends-on to shop-pddl-tests for that module. The other component which was depending on the warns-check, shop-internal-tests, already depends on the shop-test-helper component.
|
The version of |
rpgoldman
left a comment
rpgoldman
left a comment
There was a problem hiding this comment.
If you could make that change and verify it, I will get this merged.
| :pathname "tests/" | ||
| :components ((:file "common"))) | ||
| :components ((:file "common") | ||
| (:file "warns-check"))) |
There was a problem hiding this comment.
I think we should check to see if this macro is already defined by FiveAM (there's a pull request for it). So at the top of warns-check, add:
(eval-when (:compile-toplevel :load-toplevel :execute)
(when (fboundp (uiop:intern* '#:warns :fiveam)) (pushnew :fiveam-warns features)))
#+(not fiveam-warns)
<warns definition>If I knew that this was going to be added at a particular FiveAM version, I could do this in a cleaner way, but 🤷♂️
There was a problem hiding this comment.
I added the check before the warns definition here: ccb211d
Let me know if that's not what you are expecting and I can fix it.
There was a problem hiding this comment.
The CI tests are failing after adding the check for existence of warns. At a glance, the test failure looks unrelated to the change, so I’m confused at the moment.
I’ll run the tests locally later today to see if I can replicate and debug the test failure.
There is an open pull request to add the `warns` check to fiveam. If that pull request is merged, the `warns` check here should no longer be used. The check added by this commit will ensure that the `warns` defined in warns-check.lisp is only used if `warns` is not already defined. See lispci/fiveam#81
|
@matthewdehaven Checking |
|
Interesting: SBCL passes on |
|
I have found what's wrong. Somehow the call to |
The tests were so big that it was hard to tell just what was failing. Change this too-big test into a suite containing a number of sub-tests.
By moving warns-check.lisp into the shop-test-helper component, then adding a depends-on to shop-pddl-tests for that module. The other component which was depending on the warns-check, shop-internal-tests, already depends on the shop-test-helper component.
Addresses #138