Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Conversation

@bnavigator
Copy link

@bnavigator bnavigator commented Mar 15, 2021

abusing the ext parameter of Testdir.makefile for the full filename does not work with pytest 6.

https://docs.pytest.org/en/stable/reference.html#pytest.Pytester.makefile
AFAICT the correct call signature has always been like that: https://docs.pytest.org/en/4.6.x/reference.html#_pytest.pytester.Testdir.makefile

@bnavigator bnavigator changed the title fix pytest.tmpdir.makefile call fix pytest.Testdir.makefile call Mar 15, 2021
@doublethefish
Copy link

doublethefish commented Dec 28, 2021

I believe this patch won't work as expected because it fails to write a .toml file; this is required by the test infrastructure.

See #56 for a more comprehensive patch where we use makepyprojecttoml instead, as well as patch the use of pathlib.* APIs.

@bnavigator
Copy link
Author

I believe this patch won't work as expected because it fails to write a .toml file; this is required by the test infrastructure.

Why would it fail to write said .toml file?

See #56 for a more comprehensive patch where we use makepyprojecttoml instead, as well as patch the use of pathlib.* APIs.

Agreed. Closing in favor of #56.

Is this repo actually still maintained?

@bnavigator bnavigator closed this Dec 28, 2021
@doublethefish
Copy link

I believe this patch won't work as expected because it fails to write a .toml file; this is required by the test infrastructure.

Why would it fail to write said .toml file?

I was wrong, I had missed the pyproject kwarg, so pyeproject.toml will be created. Apologies.

Is this repo actually still maintained?

++100?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants