Skip to content

Comments

Added Fastly secret to shop configuration#211

Merged
Patrick Derks (TrayserCassa) merged 3 commits intomainfrom
feat/add-fastly-secret
Feb 6, 2026
Merged

Added Fastly secret to shop configuration#211
Patrick Derks (TrayserCassa) merged 3 commits intomainfrom
feat/add-fastly-secret

Conversation

@renaudhager
Copy link
Member

This pull request enhances the Shopware Helm chart by adding support for Fastly configuration and usage data consent within the shopConfiguration section. These changes allow for more flexible deployment configurations, particularly for environments using Fastly CDN and requiring explicit usage data consent settings.

Shop configuration enhancements:

  • Added a usageDataConsent field to shopConfiguration in both the values.yaml and the store.yaml template, with a default value of "revoked" if not specified. [1] [2]
  • Introduced an optional fastly configuration block under shopConfiguration, allowing users to specify serviceRef and tokenRef for Fastly integration. This includes key and name fields for both references. [1] [2]

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the Shopware Helm chart by adding support for Fastly CDN integration and usage data consent configuration. The changes enable users to optionally configure Fastly service references and API token references within the shop configuration, along with an explicit usage data consent field that defaults to "revoked".

  • Added usageDataConsent field to shop configuration with default value "revoked"
  • Introduced optional fastly configuration block for Fastly CDN integration with serviceRef and tokenRef fields

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
charts/shopware/values.yaml Added commented example configuration showing the new usageDataConsent and fastly fields under shopConfiguration
charts/shopware/templates/store.yaml Implemented template logic to render usageDataConsent with default value and conditional fastly configuration block

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shopConfiguration:
currency: {{ .Values.store.shopConfiguration.currency | default "EUR" }}
locale: {{ .Values.store.shopConfiguration.locale | default "en-GB" }}
usageDataConsent: {{ .Values.store.shopConfiguration.usageDataConsent | default "revoked" }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should change this to allowed because we want usageData from externals, but for us it must be revoked, so we should double check in our overlays

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shopware/shopware-operator#167

I also fixed the operator default values 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@TrayserCassa Patrick Derks (TrayserCassa) merged commit be3d7cc into main Feb 6, 2026
5 checks passed
@TrayserCassa Patrick Derks (TrayserCassa) deleted the feat/add-fastly-secret branch February 6, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants