feat: allow custom images in debug instance with conditional store st…#175
Open
Tom Bojer (tombojer) wants to merge 2 commits intomainfrom
Open
feat: allow custom images in debug instance with conditional store st…#175Tom Bojer (tombojer) wants to merge 2 commits intomainfrom
Tom Bojer (tombojer) wants to merge 2 commits intomainfrom
Conversation
Tom Bojer (tombojer)
force-pushed
the
variable-debug-instances
branch
2 times, most recently
from
24049d1 to
7a3d991
Compare
Tom Bojer (tombojer)
force-pushed
the
variable-debug-instances
branch
from
7a3d991 to
0f2ef95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…atus check
Currently a
StoreDebugInstancecan only be started when the store is inReadystate.This is counterintuitive for debugging.
This change enables the user to use a custom image and ignore the store status check.