Conversation
Summary of ChangesHello @nt3rp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to rectify a broken version release process by introducing a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix the release process by updating the project version and adding a configuration file for git-cliff. The changes are straightforward and seem to address the issue described. I've provided one suggestion to simplify the new cliff.toml configuration file for better clarity and maintainability.
| # https://git-cliff.org/docs/configuration | ||
|
|
||
| [git] | ||
| conventional_commits = false No newline at end of file |
There was a problem hiding this comment.
Would suggest that we still add this file to ensure that everyone uses the same config, but with conventional_commits = true
| conventional_commits = false | |
| conventional_commits = true |
Summary
Attempts to fix version release process to deploy new printserver version
Additional Context
make releasedepends on a combination of git tags,pyproject.tomlversion, and the output ofgit-cliff; it looks like this has been partially broken since the previous-previous release (2.4.3?).It's not clear to me how 2.4.4 was released—since
git cliffexpects conventional commits—but this PR adds in basic config forgit cliffwhich should unblock that, and bumps the version number....I don't know if this will fully resolve the issue, but it should help (I hope)