Skip to content

Updates project version#41

Open
nt3rp wants to merge 2 commits intomainfrom
nick/fix-version-number-bump
Open

Updates project version#41
nt3rp wants to merge 2 commits intomainfrom
nick/fix-version-number-bump

Conversation

@nt3rp
Copy link
Copy Markdown
Contributor

@nt3rp nt3rp commented Dec 29, 2025

Summary
Attempts to fix version release process to deploy new printserver version

Additional Context
make release depends on a combination of git tags, pyproject.toml version, and the output of git-cliff; it looks like this has been partially broken since the previous-previous release (2.4.3?).

It's not clear to me how 2.4.4 was released—since git cliff expects conventional commits—but this PR adds in basic config for git cliff which should unblock that, and bumps the version number.

...I don't know if this will fully resolve the issue, but it should help (I hope)

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @nt3rp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to rectify a broken version release process by introducing a git-cliff configuration and updating the project's version number. The changes are intended to unblock the deployment of new printserver versions, which has been problematic due to dependencies on git tags, pyproject.toml version, and git-cliff output.

Highlights

  • Version Release Process Fix: This PR attempts to resolve issues with the project's version release process, which has been partially broken since previous releases, particularly concerning git-cliff integration.
  • git-cliff Configuration: A new cliff.toml file is introduced to configure git-cliff, explicitly disabling conventional commit requirements and filtering unconventional commits to unblock the release mechanism.
  • Project Version Bump: The project version is updated from "2.4.3" to "2.4.5" in both pyproject.toml and uv.lock to reflect the intended new release.
  • Dependency Lock File Update: The uv.lock file's revision is incremented, and the printserver package version within it is aligned with the new project version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@nt3rp nt3rp marked this pull request as ready for review December 29, 2025 15:19
@nt3rp nt3rp requested review from a team and h December 29, 2025 15:19
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the release process by updating the project version and adding a configuration file for git-cliff. The changes are straightforward and seem to address the issue described. I've provided one suggestion to simplify the new cliff.toml configuration file for better clarity and maintainability.

Comment thread cliff.toml Outdated
@nt3rp nt3rp closed this Dec 29, 2025
@h h reopened this Dec 29, 2025
Comment thread cliff.toml
# https://git-cliff.org/docs/configuration

[git]
conventional_commits = false No newline at end of file
Copy link
Copy Markdown
Member

@h h Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would suggest that we still add this file to ensure that everyone uses the same config, but with conventional_commits = true

Suggested change
conventional_commits = false
conventional_commits = true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants