Conversation
Refactored `use` command to improve usability by introducing a `GetVars` function that returns the functions to be exported for use by `exec`. Implemented an `exec` that simply passes the args as-is to the specified binary via `syscall.Exec`. Fixes shyiko#285
|
I've taken the liberty of bumping the version in the changelog, hope that's not going to be a problem. Could you let me know when you release the new binary? Hope it's sooner than later :) Thanks. |
|
@ketan thank you! This looks great. Any chance you would be willing to do something about Windows (syscall.Exec returns EWINDOWS)? Ideally, exec should work on all target OSs. A message showing that it's not supporfted on Windows would work too I suppose. |
|
Sorry, I did not see |
|
FYI: |
|
@ketan I understand. I'm not asking to replace syscall.Exec. It should stay. All we need is runtime.GOOS == "windows" case :). |
|
To be honest, my motivation of doing |
|
Up to you. I'm fine with either case. |
|
Any news about this feature? |
|
Not a followup of this feature per se, but you could have a look at https://github.com/nicerloop/jabba-wrapper |
Refactored
usecommand to improve usability by introducing aGetVarsfunction that returns the functions to be exported for use by
exec.Implemented an
execthat simply passes the args as-is to the specifiedbinary via
syscall.Exec.Fixes #285