Prevent over stripping a drive letter in Windows#536
Open
kai2nenobu wants to merge 2 commits intoshyiko:masterfrom
Open
Prevent over stripping a drive letter in Windows#536kai2nenobu wants to merge 2 commits intoshyiko:masterfrom
kai2nenobu wants to merge 2 commits intoshyiko:masterfrom
Conversation
…n windows In windows, colon (:) is a separator for a drive letter. So OS-specific path list separator (; in windows) should be used instead of colon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR let
useanddeactivatecommand use an OS-specific path list separator instead of:.This resolves #335.
About test
Existing tests fail in Windows.
Existing test result in windows on master (dcf0285)
So I added new tests and let existing tests skip in Windows. However, I'm not familiar with golang testing, please review test code and let me know if there are smarter manners.
I tested this PR in travis ci on three OSs (linux, macos, windows) and two golang versions (1.9, 1.13). See travis ci log for more details.