Skip to content

⚡ Optimize eleventy-plugin-local-images to skip JSDOM when unnecessary #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
si wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize eleventy-plugin-local-images to skip JSDOM when unnecessary #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions third_party/eleventy-plugin-local-images/.eleventy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,20 @@ const grabRemoteImages = async (rawContent, outputPath) => {
let content = rawContent;

if (outputPath && outputPath.endsWith(".html")) {
// Optimization: fast exit if content doesn't contain images or metadata
// Only apply this optimization if the selector is one of the known defaults
// to avoid breaking custom selectors.
const projectSelector =
"img,amp-img,amp-video,meta[property='og:image'],meta[name='twitter:image'],amp-story";

if (selector === "img" || selector === projectSelector) {
const triggers =
/<img|<amp-(?:img|video|story)|property=['"]og:image['"]|name=['"]twitter:image['"]/i;
if (!triggers.test(content)) {
return content;
}
}

const dom = new JSDOM(content);
const images = [...dom.window.document.querySelectorAll(selector)];

Expand Down