Skip to content

⚡ Optimize remote image downloads with request coalescing #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
si wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize remote image downloads with request coalescing #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 31 additions & 18 deletions third_party/eleventy-plugin-local-images/.eleventy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,30 +8,43 @@ const metadata = require("../../_data/metadata.json");

let config = { distPath: "_site", verbose: false, attribute: "src" };

const pendingDownloads = new Map();

const downloadImage = async (url) => {
if (config.verbose) {
console.log("eleventy-plugin-local-images: Attempting to copy " + url);
}

try {
const imgBuffer = await fetch(url, { redirect: "follow" })
.then((res) => {
if (!res.ok) {
console.warn(
`[local-images] Skipping remote image ${url} — HTTP ${res.status}`
);
return null;
} else if (res.status == 200) {
return res;
} else {
throw new Error(`File "${url}" not found`);
}
})
.then((res) => res.buffer());
return imgBuffer;
} catch (error) {
console.log(error);
if (pendingDownloads.has(url)) {
return pendingDownloads.get(url);
}

const downloadPromise = (async () => {
try {
const imgBuffer = await fetch(url, { redirect: "follow" })
.then((res) => {
if (!res.ok) {
console.warn(
`[local-images] Skipping remote image ${url} — HTTP ${res.status}`
);
return null;
} else if (res.status == 200) {
return res;
} else {
throw new Error(`File "${url}" not found`);
}
})
.then((res) => (res ? res.buffer() : null));
return imgBuffer;
} catch (error) {
console.log(error);
} finally {
pendingDownloads.delete(url);
}
})();

pendingDownloads.set(url, downloadPromise);
return downloadPromise;
};

const getFileType = (filename, buffer) => {
Expand Down