Skip to content

⚡ Parallelize image format generation #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
si wants to merge 4 commits into
base: main
Choose a base branch
from
Open

⚡ Parallelize image format generation #35

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
050da92
feat(perf): Parallelize image format generation in img-dim.js
google-labs-jules[bot] Feb 17, 2026
7d71061
feat(perf): Limit concurrency in img-dim.js to fix CI failure
google-labs-jules[bot] Feb 17, 2026
1fa7071
fix(perf): Reduce image concurrency to 1 to fix CI
google-labs-jules[bot] Feb 17, 2026
87a41c8
fix(perf): Serialize mandatory image generation, parallelize optionals
google-labs-jules[bot] Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions _11ty/img-dim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,14 @@ const processImage = async (img, outputPath) => {
if (!fallback) {
return;
}
const avifFallback = await setSrcset(avif, src, "avif");
const [avifFallback, webpFallback] = await Promise.all([
setSrcset(avif, src, "avif"),
setSrcset(webp, src, "webp"),
]);
if (avifFallback) {
avif.setAttribute("type", "image/avif");
picture.appendChild(avif);
}
const webpFallback = await setSrcset(webp, src, "webp");
if (webpFallback) {
webp.setAttribute("type", "image/webp");
picture.appendChild(webp);
Expand Down Expand Up @@ -153,7 +155,11 @@ const dimImages = async (rawContent, outputPath) => {
const images = [...dom.window.document.querySelectorAll("img,amp-img")];

if (images.length > 0) {
await Promise.all(images.map((i) => processImage(i, outputPath)));
const concurrencyLimit = 1;
for (let i = 0; i < images.length; i += concurrencyLimit) {
const chunk = images.slice(i, i + concurrencyLimit);
await Promise.all(chunk.map((img) => processImage(img, outputPath)));
}
content = dom.serialize();
}
}
Expand Down