Recursive interpolation stripping in tests and definition-key expression fallback#17
Closed
Recursive interpolation stripping in tests and definition-key expression fallback#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
{{ ... }}interpolation for nested definition structures so definition-key handling in tests matches runtime behavior.{{ }}braces.Description
definitionKeyExpressionFallbackoption toTemplateCompileOptionswith a default offalseto control parsing fallback behavior.TemplateCompilerImplto pass the new option intoRootTemplateExpressionFactoryand to use a dedicatedcompileDefinitionObjectentrypoint for compiling definition maps.RootTemplateExpressionFactoryto support optional key parsing fallback viaparseObjectKey(..., allowFallback), addedcompileDefinitionObject, logging on parse failures, and helper methodscontainsExpressionandlooksLikeExpressionto decide when to treat raw keys as expressions.TemplateCompilerImplIntegrationTestto recursively strip interpolation from nested definition values usingstripDefinitionValueand added teststestScenarioWithDefinitionKeysWithoutBracesandtestScenarioWithDefinitionKeysAndFallbackalong withstripInterpolation/isSwitchOrRangeKeyhelpers.Testing
Codex Task