Skip to content

meta tags added for pages #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

meta tags added for pages #96

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bc37c78
meta tags added for pages
Jun 4, 2020
d10c6da
removed debugger
Jun 5, 2020
d78016f
og-img added
Jun 26, 2020
042618a
site name fixed
Jun 30, 2020
c56727f
twitter img alternate added
Jun 30, 2020
39690ac
compressed card:img hosted it on imgbb
Jun 30, 2020
738d8ab
default props added
Jun 30, 2020
551d3c2
content changed
Jun 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"prismjs": "^1.19.0",
"react": "^16.8.9",
"react-dom": "^16.8.9",
"react-helmet": "^6.0.0",
"react-scripts": "^3.4.0",
"react-twitter-embed": "^3.0.3",
"react-ui": "1.0.0-beta.26",
Expand Down
32 changes: 32 additions & 0 deletions packages/docs/src/components/head.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import React from "react";
import { Helmet } from "react-helmet";
import PropTypes from 'prop-types';

export const Head = ({title, description}) =>{
return(
<Helmet>
<meta name="viewport" content="minimum-scale=1, initial-scale=1, width=device-width" />
<title>{title}</title>
<meta name="description" content={description} />

{/* twitter */}
<meta name="twitter:card" content="summary" />
<meta name="twitter:site" content="React-ui" />
<meta name="twitter:title" content={title} />
<meta name="twitter:description" content={description} />
<meta name="twitter:image" content="https://user-images.githubusercontent.com/1863771/76433547-c0e94e80-63b4-11ea-9cca-c859226e5021.png" />

{/* facebook */}
<meta property="og:type" content="website" />
<meta property="og:title" content={title} />
<meta property="og:description" content={description} />
<meta property="og:image" content="https://user-images.githubusercontent.com/1863771/76433547-c0e94e80-63b4-11ea-9cca-c859226e5021.png" />
<meta property="og:ttl" content="604800" />
</Helmet>
)
}

Head.propTypes = {
description: PropTypes.string,
title: PropTypes.string,
};
1 change: 1 addition & 0 deletions packages/docs/src/components/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ export * from '../components/page'
export * from '../components/section'
export * from '../components/list'
export * from '../components/divider'
export * from '../components/head'
33 changes: 20 additions & 13 deletions packages/docs/src/components/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,26 @@ import React from 'react'
import { Stack, calc } from 'react-ui'

import { Heading, Tagline } from './typography'
import { Head } from './head'

export const Page = ({ title, tagline, badges, ...props }) => (
<Stack direction="vertical" gap={16} marginBottom={calc('16 * 2')}>
{title ? (
<Stack as="section" direction="vertical" gap={2}>
<Stack justify="space-between" align="center">
<Heading>{title}</Heading>
export const Page = ({ title, tagline, badges, ...props }) => {
return (
<>
<Head title={title} description={tagline} />
<Stack direction="vertical" gap={16} marginBottom={calc('16 * 2')}>
{title ? (
<Stack as="section" direction="vertical" gap={2}>
<Stack justify="space-between" align="center">
<Heading>{title}</Heading>

<span>{badges || null}</span>
</Stack>
<Tagline>{tagline}</Tagline>
<span>{badges || null}</span>
</Stack>
<Tagline>{tagline}</Tagline>
</Stack>
) : null}
{props.children}
</Stack>
) : null}
{props.children}
</Stack>
)
</>

)
}
15 changes: 15 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13930,6 +13930,16 @@ react-helmet-async@^1.0.2:
react-fast-compare "^2.0.4"
shallowequal "^1.1.0"

react-helmet@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/react-helmet/-/react-helmet-6.0.0.tgz#fcb93ebaca3ba562a686eb2f1f9d46093d83b5f8"
integrity sha512-My6S4sa0uHN/IuVUn0HFmasW5xj9clTkB9qmMngscVycQ5vVG51Qp44BEvLJ4lixupTwDlU9qX1/sCrMN4AEPg==
dependencies:
object-assign "^4.1.1"
prop-types "^15.7.2"
react-fast-compare "^2.0.4"
react-side-effect "^2.1.0"

react-hotkeys@2.0.0:
version "2.0.0"
resolved "https://registry.yarnpkg.com/react-hotkeys/-/react-hotkeys-2.0.0.tgz#a7719c7340cbba888b0e9184f806a9ec0ac2c53f"
Expand Down Expand Up @@ -14096,6 +14106,11 @@ react-scripts@^3.4.0:
optionalDependencies:
fsevents "2.1.2"

react-side-effect@^2.1.0:
version "2.1.0"
resolved "https://registry.yarnpkg.com/react-side-effect/-/react-side-effect-2.1.0.tgz#1ce4a8b4445168c487ed24dab886421f74d380d3"
integrity sha512-IgmcegOSi5SNX+2Snh1vqmF0Vg/CbkycU9XZbOHJlZ6kMzTmi3yc254oB1WCkgA7OQtIAoLmcSFuHTc/tlcqXg==

react-sizeme@^2.6.7:
version "2.6.12"
resolved "https://registry.yarnpkg.com/react-sizeme/-/react-sizeme-2.6.12.tgz#ed207be5476f4a85bf364e92042520499455453e"
Expand Down