Upgrade turn notifications: new v2 channel, higher importance, icons, and defaults#3
Merged
siddheshkothadi merged 1 commit intomainfrom Mar 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
turn_events_v2so channel defaults are reapplied.Description
TURN_CHANNEL_IDtoturn_events_v2to force a fresh notification channel with updated defaults.NotificationManager.IMPORTANCE_HIGH, enabled vibration and lights, and kept badges viasetShowBadge(true).R.drawable.ic_launcher_foregroundas the small icon, attempt to load the app icon as a large icon usingtoBitmap, set priority toPRIORITY_HIGH, and apply.setDefaults(NotificationCompat.DEFAULT_ALL).toBitmapand wrapped large icon extraction withrunCatchingto safely handle failures.Testing
Codex Task