Draft
Conversation
Owner
sidju
commented
Sep 8, 2025
sidju
commented
- Leave separating the command in/output from the editor to the UI, instead of printing ! and assuming this will act as a separator (not true for TUI). (Had a downside of being a breaking change for the UI trait)
- Give a default implementation for MacroStore for a HashMap<String, Macro>. (Had a downside of requiring clearer specification of type if not populating the store, mainly noticed for minimal example and tests)
- As a small fix added newlines between history entries when printing history.
- Leave separating the command in/output from the editor to the UI, instead of printing ! and assuming this will act as a separator (not true for TUI). (Had a downside of being a breaking change for the UI trait) - Give a default implementation for MacroStore for a HashMap<String, Macro>. (Had a downside of requiring clearer specification of type if not populating the store, mainly noticed for minimal example and tests) - As a small fix added newlines between history entries when printing history.
Owner
Author
|
I'll need to decide if I merge and release this as-is (0.15.0), or if I do a full finish up of the TODO.md and issues and release it as a 1.0.0 release. |
added 2 commits
September 16, 2025 20:49
When tagging the first line is tagged as `'tag` and the last as `` `tag``, allowing to quickly tag a selection and return to it precisely. A potential shorthand of `"tag` would equal ``'tag,`tag``, but that won't be implemented until the need has been felt.
It selects the other index in selection, so the starting index if used in the ending position and the ending index if used in the starting position. This also can be used to use the non-default index for commands that only take a singular index, for example `:a` appends after the first line in current selection, or which take index arguments, `,3m:` moves to after first line in current selection.
added 2 commits
September 17, 2025 15:11
Fixes failing tests from using `:` as index literal.
This reduces the API/command breakage by changing how the tag resolution works. I also find this solution to be a bit more obvious and easier to make visible to the users.
Owner
Author
|
To be clear, I'm aiming to close off most if not all the TODO items in this PR |
added 2 commits
October 22, 2025 12:35
No tests as of yet, testing is next
Removed ModificationMode::Squash option since it was near identical to Default.
added 7 commits
November 9, 2025 00:06
- Support absolute indexes ('*' as prefix)
- Support redo-all ('$')
- Support basic add/subtract operations
- Add explicit literal for current index ('.')
Add support for flexible addressing, printing full history, printing absolute indices instead of relative to current.
- = no longer allows a selection (could be added back if requested). - It accepts flags to print: - s for selection - a for full status - Defaults to selection if no flags given (More flags will be added later)
First try properly utilizing an AI coding assistant, not easy to make it produce good results but admittedly productive (with some awareness of it all needing a proper thorough review and verification by a real developer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.