Skip to content

Fix parse #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix parse #38

wants to merge 2 commits into from

Conversation

@jonnynux
Copy link

@jonnynux jonnynux commented Oct 7, 2020

When using seconds I noticed that the last run were not correct. For example:

  • Rule (* * * * *) and time 15:15:01, the last execution must be 15:15:00, not 15:14:00.
  • Same having the rule (* * * * *) and time 15:15:00, the last execution must be 15:15:00, exactly now, not 15:14:00.

Also:

  • fixed some deprecations in tests
  • fixed style
  • added new tests

stakach
stakach approved these changes Oct 7, 2020
View reviewed changes
Copy link

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnynux jonnynux mentioned this pull request Oct 9, 2020
Open
@jonnynux
Copy link
Author

jonnynux commented Oct 21, 2020

@stakach Does anybody still supports this gem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stakach stakach stakach approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonnynux @stakach