refactor(form): make errrormessageid required

[akashsonune]

BREAKING CHANGE: The property SiFormItemControl.errormessageId is now required. All implementations of SiFormItemControl must provide this property to ensure proper accessibility support for error messages.

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.

---

• I confirm that this MR follows the contribution guidelines.

[gemini-code-assist]

Summary of Changes

Hello @akashsonune, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a breaking change by making the errormessageId property mandatory within the SiFormItemControl interface. This change is designed to significantly enhance accessibility by guaranteeing that all form item controls consistently provide an identifier for their associated error messages, which is vital for assistive technologies like screen readers.

Highlights

• Interface Modification: The errormessageId property in the SiFormItemControl interface has been changed from optional to required, ensuring all implementations provide this crucial accessibility identifier.
• Directive Implementation: The SiFormlyFormFieldProviderDirective now explicitly implements the errormessageId property, dynamically computing its value based on the field's ID to maintain consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request makes the errormessageId property on the SiFormItemControl interface required, which is a breaking change. This is a good step towards improving accessibility for form error messages. The change is correctly implemented in SiFormlyFormFieldProviderDirective to satisfy the new interface requirement. However, I've noted an issue with the implementation in SiFormlyFormFieldProviderDirective where it doesn't fully adhere to the contract of SiFormItemControl regarding the assignment of aria-describedby, which is crucial for accessibility. Please see my detailed comment.

[github-actions]

Documentation.
Examples.
Playwright report.

Coverage Reports:

• element-ng
• element-translate-ng

[spike-rabbit]

Seems like many of our examples are broken. Please fix them ideally in another PR upfront so we don't mix the changes here.

[github-actions]