-
Notifications
You must be signed in to change notification settings - Fork 13
refactor(ag-grid): remove form item wrapper #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
akashsonune
commented
Jan 30, 2026
- I confirm that this MR follows the contribution guidelines.
Summary of ChangesHello @akashsonune, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the ag-date-input component by removing the si-form-item wrapper. This change simplifies the component by removing an unnecessary layer, which is appropriate for its use within ag-grid filters where a full form item with a label is not required. The code is now cleaner and more direct. The changes are correct and improve maintainability.
|
Documentation. Coverage Reports: |
spike-rabbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@mistrykaran91 There's slight change in the input position, but i guess it makes sense - https://d33c9dcnqinn2a.cloudfront.net/pr-1403/playwright-report/#?testId=38358113ca929b17eddb-646d7dab49221774eb5b |
8f48c5f to
64bb5e7
Compare
64bb5e7 to
03b8e89
Compare
spike-rabbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍