-
Notifications
You must be signed in to change notification settings - Fork 13
docs: add the design language colors #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
timowolf
commented
Jan 30, 2026
- I confirm that this MR follows the contribution guidelines.
Summary of ChangesHello @timowolf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the management of design language colors by introducing a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation to align with the new design language colors. It refactors several documentation files to use new color tokens and centralizes the color palette definitions by including them from a single source file. While this is a good step for maintainability, there is a critical issue with a hardcoded local file path in docs/fundamentals/colors/si-ref.md which will break the documentation build for other developers and on CI. Additionally, a color palette definition for 'Orchid' seems to be missing in the updated data-visualization-colors.md file.
f156571 to
b562309
Compare
|
Documentation. Coverage Reports: |
b562309 to
0e50893
Compare
panch1739
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timowolf this is perfeeeect! I cross-checked with Figma and it seems all ok :)
Im so glad i dont have to do this manually
spike-rabbit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
0e50893 to
efd5346
Compare
efd5346 to
eb1c184
Compare
eb1c184 to
1a435bd
Compare