Skip to content

Conversation

@spike-rabbit
Copy link
Member

@spike-rabbit spike-rabbit commented Jan 30, 2026

The previous overflow:hidden approach was not sufficient in certain cases (exact reason is unknown).
Using contain: layout is anyway better
since it decouples the internal layout.

Please check in Safari. There used to be a problem when using transform (which should be preferred over margin as it can be hardware accelerated)

Describe in detail what your merge request does and why. Add relevant
screenshots and reference related issues via Closes #XY or Related to #XY.


@gemini-code-assist
Copy link

Summary of Changes

Hello @spike-rabbit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where content within the list details component could appear partially visible by updating its CSS styling. It transitions from an overflow-x: hidden approach to contain: layout for better rendering isolation and refactors the component's animation to leverage CSS transform properties, resulting in more efficient and visually consistent transitions.

Highlights

  • CSS Property Update: Replaced the overflow-x: hidden property with contain: layout in the main container of the list details component. This change aims to prevent content from being half visible and improves layout isolation, enhancing rendering performance and predictability.
  • Animation Refactor: The animation for the .list-details element has been refactored to use transform: translateX instead of margin-inline-start. This provides a smoother and more performant transition when the details panel is activated, as transform changes typically avoid triggering layout recalculations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CSS for the si-list-details component to address a content visibility issue. The changes involve replacing overflow-x: hidden with contain: layout for better layout containment and switching from margin-based animations to transform-based animations for improved performance. While these are positive changes, the switch to transform: translateX introduces a regression for right-to-left (RTL) language support, as it's a physical property that doesn't adapt to text direction. My review highlights this issue and provides recommendations for a fix.

@github-actions
Copy link

The previous `overflow:hidden` approach was not sufficient
in certain cases (exact reason is unknown).
Using `contain: layout` is anyway better
since it decouples the internal layout.
@spike-rabbit spike-rabbit force-pushed the fix/list-details/mobile-half-visible branch from d9c0c2b to 1544bd6 Compare January 30, 2026 13:56
@spike-rabbit spike-rabbit marked this pull request as ready for review January 30, 2026 14:12
@spike-rabbit spike-rabbit requested a review from a team as a code owner January 30, 2026 14:12
@timowolf timowolf added this to the 49.0.0 milestone Jan 30, 2026
@timowolf timowolf added the bug Something isn't working label Jan 30, 2026
@timowolf timowolf enabled auto-merge (rebase) January 30, 2026 15:04
@github-actions
Copy link

Code Coverage

@timowolf timowolf merged commit 9b43b9d into main Jan 30, 2026
10 checks passed
@timowolf timowolf deleted the fix/list-details/mobile-half-visible branch January 30, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants