-
Notifications
You must be signed in to change notification settings - Fork 13
fix(list-details): prevent half visible content #1406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @spike-rabbit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where content within the list details component could appear partially visible by updating its CSS styling. It transitions from an Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the CSS for the si-list-details component to address a content visibility issue. The changes involve replacing overflow-x: hidden with contain: layout for better layout containment and switching from margin-based animations to transform-based animations for improved performance. While these are positive changes, the switch to transform: translateX introduces a regression for right-to-left (RTL) language support, as it's a physical property that doesn't adapt to text direction. My review highlights this issue and provides recommendations for a fix.
|
Documentation. Coverage Reports: |
The previous `overflow:hidden` approach was not sufficient in certain cases (exact reason is unknown). Using `contain: layout` is anyway better since it decouples the internal layout.
d9c0c2b to
1544bd6
Compare
The previous
overflow:hiddenapproach was not sufficient in certain cases (exact reason is unknown).Using
contain: layoutis anyway bettersince it decouples the internal layout.
Please check in Safari. There used to be a problem when using transform (which should be preferred over margin as it can be hardware accelerated)