fix(forms): always require a label in si-form-item
#613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not having a label is an a11y flaw. This was not enforced before to maintain compatibility with the legacy mode. Since the legacy mode was officially dropped we no longer need this. BREAKING CHANGE: The `si-form-item` now always requires a label. Not having a label is an accessibility flaw.
spike-rabbit
force-pushed
the
fix/forms/form-items-must-have-a-label
branch
from
b4fb6f0 to
8116100
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not having a label is an a11y flaw.
This was not enforced before to maintain compatibility with the legacy mode. Since the legacy mode was officially dropped we no longer need this.
BREAKING CHANGE: The
si-form-itemnow always requires a label. Not having a label is an accessibility flaw.