Skip to content

Conversation

@panch1739
Copy link
Member

This PR updates the button docs to start introducing the square variant.

@kfenner I'm unsure whether we should start documenting the variant slowly...perhaps just by mentioning its existence first. Later, we can add more context, such as when to use the square versus the circle variant.
To do this properly, I’ll need to go through each component, compare it with IX, and uncover the underlying pattern.

I’ve updated the Figma file, so the correct styling is now available. However, I couldn’t find the PR where this variant was introduced in the code...so im unsure if creating a separate issue to align the styling.


@panch1739 panch1739 added documentation Improvements or additions to documentation ux Marks all UX related topics (UX team is working on or UX input is required) labels Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Copy link
Member

@kfenner kfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panch1739 Great start, thank you 🙏

@dauriamarco Can you make sure this is aligned with your implementation efforts and gets merged at the same time?

@kfenner kfenner removed their assignment Dec 31, 2025
Co-authored-by: Loris Janner <78341770+ljanner@users.noreply.github.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@panch1739
Copy link
Member Author

@panch1739 Great start, thank you 🙏

@dauriamarco Can you make sure this is aligned with your implementation efforts and gets merged at the same time?

@kfenner This PR was done at beginning november...but since then, we have figured out where to integrate them. I have here the full updated docs... #1218. Should we close this PR and directly go with the full docs?

@github-actions
Copy link

Code Coverage

@panch1739
Copy link
Member Author

@spike-rabbit I realised that we need to close this PR, as is already outdated, in favor of #1218

@panch1739 panch1739 closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ux Marks all UX related topics (UX team is working on or UX input is required)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants