-
Notifications
You must be signed in to change notification settings - Fork 13
docs(buttons): update icon button docs #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Documentation. Coverage Reports: |
kfenner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panch1739 Great start, thank you 🙏
@dauriamarco Can you make sure this is aligned with your implementation efforts and gets merged at the same time?
Co-authored-by: Loris Janner <78341770+ljanner@users.noreply.github.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@kfenner This PR was done at beginning november...but since then, we have figured out where to integrate them. I have here the full updated docs... #1218. Should we close this PR and directly go with the full docs? |
|
@spike-rabbit I realised that we need to close this PR, as is already outdated, in favor of #1218 |
This PR updates the button docs to start introducing the square variant.
@kfenner I'm unsure whether we should start documenting the variant slowly...perhaps just by mentioning its existence first. Later, we can add more context, such as when to use the square versus the circle variant.
To do this properly, I’ll need to go through each component, compare it with IX, and uncover the underlying pattern.
I’ve updated the Figma file, so the correct styling is now available. However, I couldn’t find the PR where this variant was introduced in the code...so im unsure if creating a separate issue to align the styling.