Small improvements on demos #109
Open
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter merging fix_OpenSSL_4_0_compat
DDvO
requested review from
Copilot and
rajeev-0
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR addresses issues with the CI pipeline following the shutdown of Insta Demo CA at the end of 2025, along with configuration improvements for OpenSSL demonstrations.
Changes:
- Updated libsecutils subproject to a newer commit
- Commented out the OpenSSL 3.4 workaround in demo.cnf and added a new SAN configuration section
- Disabled the wget check for the now-defunct Insta Demo CA website in the Makefile
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| libsecutils | Updated subproject commit reference |
| config/demo.cnf | Commented out OpenSSL 3.4 workaround and added MAC address SAN configuration |
| Makefile_v1 | Commented out connectivity check to defunct Insta Demo CA website |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…f draft-ietf-lamps-macaddress-on
…which meanwhile fails as Insta Demo CA is defunct
DDvO
force-pushed
the
various_small_improvements
branch
from
f9cf4d7 to
56ebf29
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including a fix to make our CI pipeline work again after Insta Demo CA has become defunct end of 2025.