Merged
Conversation
Closed
zeschg
approved these changes
Feb 12, 2026
Collaborator
zeschg
left a comment
zeschg
left a comment
There was a problem hiding this comment.
I suggest to change the copyright year in the .gitignore file to be consistent with the other files.
Eveything else looks great!
libuta_rust/.gitignore
Outdated
| @@ -0,0 +1,17 @@ | |||
| # Unified Trust Anchor API Rust Wrapper | |||
| # | |||
| # Copyright (c) Siemens Mobility GmbH, 2025 | |||
Collaborator
There was a problem hiding this comment.
As we have 2026 in the copyright of all the other files, i suggest to do it here the same way.
libuta_rust/.gitignore
Outdated
| # This work is licensed under the terms of the Apache Software License | ||
| # 2.0. See the COPYING file in the top-level directory. | ||
| # | ||
| # SPDX-FileCopyrightText: Copyright 2025 Siemens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contribution provides a refined version of the Rust wrapper from PR #30.
This version implements several improvement suggestions from the previous PR and some additional finding by GitHub Copilot. The robustness of the code is improved by fine tuning and polishing.
Also the file structure was changed and the two crates were merged into one.
Note: what is still missing is automatic testing of the code in the pipeline.