Update grammar.py to fix parsing errors#53
Open
Moneysac90 wants to merge 1 commit intosifive:masterfrom
Open
Conversation
I encountered multiple parsing errors because the `unit_address` is considered being a hex value. This will fail on e.g. the following type of nodes.
node with a hex value but `0x` prefixed
```
uart@0x8000000 {
compatible = "xlnx";
reg = <0x1000>;
interrupts = <0x3b 0x00>;
clock = <0x2faf080>;
};
```
node using a variable name `some_var` instead of an address
```
uart@some_var {
compatible = "xlnx";
reg = <0x1000>;
interrupts = <0x3b 0x00>;
clock = <0x2faf080>;
};
```
node using invalid hex values (in the practice we saw multiple files using float values)
```
uart@0,0 {
compatible = "xlnx";
reg = <0x1000>;
interrupts = <0x3b 0x00>;
clock = <0x2faf080>;
};
```
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered multiple parsing errors because the
unit_addressis considered being a hex value. This will fail on e.g. the following type of nodes.node with a hex value but
0xprefixednode using a variable name
some_varinstead of an addressnode using invalid hex values (in the practice we saw multiple files using float values)