Skip to content

continue if no new block head received #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ppca wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

continue if no new block head received #476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8fd08
continue if no new block head received
Aug 5, 2025
21e0390
Merge branch 'develop' into xiangyi/eth_continue_when_no_new_head
Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions chain-signatures/node/src/indexer_eth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,11 +686,12 @@ async fn add_new_block_to_process(
let mut receiver_state_update_timestamp = Instant::now();
loop {
interval.tick().await;
if block_heads_rx.is_empty()
&& receiver_state_update_timestamp.elapsed() > Duration::from_secs(60)
{
tracing::warn!("No new block heads received for 60 seconds, waiting...");
receiver_state_update_timestamp = Instant::now();
if block_heads_rx.is_empty() {
if receiver_state_update_timestamp.elapsed() > Duration::from_secs(60) {
tracing::warn!("No new block heads received for 60 seconds, waiting...");
receiver_state_update_timestamp = Instant::now();
}
continue;
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The continue statement will skip the block_heads_rx.recv().await call entirely when the queue is empty, but this creates a busy loop that consumes CPU unnecessarily. The original logic allowed the recv().await call to block and wait for new messages, which is more efficient than continuously polling.

Copilot uses AI. Check for mistakes.
}
let new_block_head = match block_heads_rx.recv().await {
Ok(new_block_head) => new_block_head,
Expand Down
Loading