test: stability of test_sign_contention_5_nodes#686
Draft
jakmeier wants to merge 3 commits intosig-net:developfrom
Draft
test: stability of test_sign_contention_5_nodes#686jakmeier wants to merge 3 commits intosig-net:developfrom
jakmeier wants to merge 3 commits intosig-net:developfrom
Conversation
- increase stockpile_max to have more T+P generations in parallel - increase time for T+P generation by 1 min - increase time for signature generation by 1 min None of these are perfect solutions. The generation really should be faster. But this might help with sporadic CI error that we currently face.
Contributor
Author
|
It's not looking great for At least run 1 was successful. ( But already run 2 hits a signature generation timeout again in |
Tokio futures should not run for long. The poke on triples may take several seconds of CPU time. During this time, other tasks on the same executor will be blocked. Spawning the work to a separate thread avoids this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of these are perfect solutions.
The generation really should be faster.
But this might help with sporadic CI error that we currently face.