feat: add hasField and getFieldOrDefault template functions#635
Draft
nutellinoit wants to merge 1 commit intomainfrom
Draft
feat: add hasField and getFieldOrDefault template functions#635nutellinoit wants to merge 1 commit intomainfrom
nutellinoit wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 💡
This PR adds
hasFieldandgetFieldOrDefaulttemplate helper functions to eliminate complex nested conditionals in distribution templates. These functions use dot-notation paths (e.g., "spec.distribution.modules.aws.ebsCsiDriver.overrides.iamRoleName") to safely check nested field existence and retrieve values with defaults. Includes 56 comprehensive unit tests covering edge cases, nil handling, and type safety. Released in v0.33.2-rc.2Tests performed 🧪