[useVariable] More consistent fix for initialization logic #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slequar
reviewed
May 23, 2025
| ); | ||
| const [workbookVariable, setWorkbookVariable] = useState<WorkbookVariable>(); | ||
|
|
||
| const isFirstRender = useRef<boolean>(true); |
There was a problem hiding this comment.
I have a slight preference for a separate useEffect here, all else being equal
Contributor
Author
There was a problem hiding this comment.
Sure, I'm happy either way. The issue with that is that we'd have to eslint ignore the deps, but either way works.
abeljohn
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that there's no gap between our initialization from
useState(during render time) anduseEffect(post render) for our variable update to come in, which would be missed by this. The alternative to this is to subscribe during render time, but this makes cleanup unnecessarily tricky.