Skip to content

feat: blind all blocks before QBFT #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: unstable
Choose a base branch
from
Open

feat: blind all blocks before QBFT #694

wants to merge 7 commits into from

Conversation

petarjuki7
Copy link
Member

Issue Addressed

Addresses Issue #630

Proposed Changes

  • Blind blocks before QBFT to reduce bandwidth
  • Save original full block and compare after consensus
  • Return full block with signature if our proposal won, otherwise return blinded block

Additional Info

The signature is valid for both blinded and full versions since they share the same block header.

@petarjuki7 petarjuki7 requested a review from dknopik October 16, 2025 10:15
@petarjuki7 petarjuki7 self-assigned this Oct 16, 2025
@petarjuki7 petarjuki7 marked this pull request as ready for review October 16, 2025 10:15
petarjuki7
petarjuki7 commented Oct 16, 2025
View reviewed changes
dknopik
dknopik reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@dknopik dknopik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Please rebase on unstable.

@dknopik
Copy link
Member

dknopik commented Oct 16, 2025

@claude please review

@claude-code-actions-sigp claude-code-actions-sigp
Copy link

claude-code-actions-sigp bot commented Oct 16, 2025 •
edited by petarjuki7
Loading

Claude finished @dknopik's task —— View job

Code Review for PR #694

  • Read CLAUDE.md for repository guidelines
  • Read the modified file (anchor/validator_store/src/lib.rs)
  • View git diff to understand the changes
  • Analyze code for correctness, safety, and best practices
  • Review existing comments and concerns
  • Provide comprehensive review feedback

Job: https://github.com/sigp/anchor/actions/runs/12366854995
Branch: blind_blocks_before_qbft

@petarjuki7 petarjuki7 force-pushed the blind_blocks_before_qbft branch from 821d889 to c33e56c Compare October 16, 2025 15:34
@petarjuki7 petarjuki7 changed the base branch from release-v1.0.0 to unstable October 16, 2025 15:36
@petarjuki7 petarjuki7 force-pushed the blind_blocks_before_qbft branch from c33e56c to fbb8693 Compare October 16, 2025 15:40
@dknopik dknopik added claude-recheck triggers claude review workflow to re-run and removed claude-recheck triggers claude review workflow to re-run labels Oct 16, 2025
@petarjuki7 petarjuki7 added the claude-recheck triggers claude review workflow to re-run label Oct 16, 2025
@dknopik
Copy link
Member

dknopik commented Oct 17, 2025

@petarjuki7 your sigp membership is still private, so the tag claude-recheck tag will not work

@petarjuki7 petarjuki7 added claude-recheck triggers claude review workflow to re-run ready-for-review This PR is ready to be reviewed and removed claude-recheck triggers claude review workflow to re-run labels Oct 17, 2025
dknopik
dknopik reviewed Oct 17, 2025
View reviewed changes
Copy link
Member

@dknopik dknopik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dknopik dknopik dknopik left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@petarjuki7 petarjuki7

Labels

claude-recheck triggers claude review workflow to re-run ready-for-review This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@petarjuki7 @dknopik