Turn ProtocolIdentity into a struct#285
Merged
AgeManning merged 2 commits intosigp:masterfrom Sep 15, 2025
Merged
Conversation
AgeManning
approved these changes
Sep 15, 2025
Member
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
Yes. This looks much nicer. I agree putting it in the packet header is probably the best way to go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
While "nice way" is very subjective, I believe this is the most straightforward solution.
One thing that I am unsure about: I embedded the
ProtocolIdentityintoPacketHeader, but we could also pass it in on callingencode. On one had, the identity is part of the header, so I believe this to be the logically adequate place, on the other hand, that is an additional 8 bytes of memory per packet.Change checklist