Fix segfault if building on macOS 12+ with deployment target <=11#28
Open
taligentx wants to merge 1 commit intosigrokproject:masterfrom
Open
Fix segfault if building on macOS 12+ with deployment target <=11#28taligentx wants to merge 1 commit intosigrokproject:masterfrom
taligentx wants to merge 1 commit intosigrokproject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kIOMasterPortDefaultwas replaced bykIOMainPortDefaultas of macOS 12 and was addressed in #11. However, this causes a segfault if building on macOS 12+ with an older deployment target (for example, GitHub CI/CD runners support macOS 13+ only).This PR sets
kIOMainPortDefaultto 0:https://developer.apple.com/documentation/iokit/kiomasterportdefault
"When specifying a primary port to IOKit functions, the NULL argument indicates "use the default". This is a synonym for NULL, if you'd rather use a named constant."
libusb also handles it this way:
https://github.com/libusb/libusb/blob/dcd30cec9a633fb59a619f5bf5f5582d794c8dff/libusb/os/darwin_usb.c#L52
Tested by building SmuView on macOS 13 with a deployment target of 10.13, verified the segfault is fixed when running on a 10.13 system.