Import file had a max 4MB header size limit before it would fail. Thi…#31
Open
x0rloser wants to merge 1 commit intosigrokproject:masterfrom
Open
Import file had a max 4MB header size limit before it would fail. Thi…#31x0rloser wants to merge 1 commit intosigrokproject:masterfrom
x0rloser wants to merge 1 commit intosigrokproject:masterfrom
Conversation
…s removes that limit and lets it keep reading in more data until it succeeds or reaches the end of the file. This allows for import filetypes where channel info isnt in the first 4MB, such as when it is in a footer or inside a zip file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s removes that limit and lets it keep reading in more data until it succeeds or reaches the end of the file. This allows for import filetypes where channel info isnt in the first 4MB, such as when it is in a footer or inside a zip file.