Don't hard fail on slow systems. #624.#664
Open
jas4711 wants to merge 1 commit intosigstore:mainfrom
Open
Conversation
wlynch
requested changes
Apr 10, 2025
Member
wlynch
left a comment
wlynch
left a comment
There was a problem hiding this comment.
Thanks for the PR! One small tweak, but otherwise looks good.
jas4711
force-pushed
the
handle-slow-systems
branch
from
46ac77a to
39f7bdb
Compare
wlynch
approved these changes
Oct 10, 2025
|
Observed review from wlynch+1844673 (@wlynch) |
Author
|
Hi! Any update on review of this? Thanks. |
Patch tweak by @wlynch Signed-off-by: Simon Josefsson <simon@josefsson.org>
adityasaky
force-pushed
the
handle-slow-systems
branch
from
39f7bdb to
4fc5c11
Compare
Member
|
Hi @jas4711 thanks for the nudge. I've just rebased over main to see if the CI runs. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow signatures to take up to 5 seconds before rejecting them. See #624 for background and error messages on riscv64/s390x systems.
Release Note
Documentation