-
Notifications
You must be signed in to change notification settings - Fork 63
CI: Add test that checks that old releases can verify #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Overall seems reasonable to me!
We could make it parse all the tags but just test the latest from each of the major releases instead of all tags? I also think we could just hard-code the 1.x, 2.x, 3.x latest releases and test those against the latest tag (and only need to update this when we make a new major release).
Why not just every major release?
Should we patch it, at least for the sake of these tests? |
I think it's a little more nuanced:
I'll see if I can come up with something that doesn't require remembering to update the workflow, but still tests only a reasonable number of releases. |
I think this is not worth the trouble:
I think hard coding might be fine: it is after all the oldest versions (that we are adding now) that are likeliest to break when changes are done in future |
That makes sense to me, thanks for looking into it! |
I'm marking this ready for review: If #1578 happens, we can add 3.5.3 to the test matrix |
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Making sure that old clients can verify bundles created by current code (and current public good infrastructure) is not too difficult and would be very useful.
This is an initial attempt, keeping it draft for now:
Example run: https://github.com/jku/sigstore-python/actions/runs/18432104146
Fixes #1573