Conversation
detects when a filter input creates a LEFT JOIN to a table where the FK originates from the target (one-to-many), removes the LEFT JOIN, and wraps the filter condition in DSL.exists
Collaborator
|
Jeg er usikker på hvordan dette blir når Sånn det ser ut har jo dette aldri fungert ordentlig, så forslår følgende:
|
Erkelinux
reviewed
Mar 26, 2026
Comment on lines
+743
to
+744
| var oneToManyFilterJoin = findOneToManyFilterJoin(context, joinSetBefore, conditionListSizeBefore); | ||
| oneToManyFilterJoin.ifPresent(context.getJoinSet()::remove); |
Collaborator
There was a problem hiding this comment.
Opplever denne logikken som suspekt. Så den er allerede opprettet, men nå skal den finnes fram igjen og slettes? Hva hvis det er flere? Kan vi ikke bare la være å lage de på stedet de blir laget?
Erkelinux
reviewed
Mar 26, 2026
| "nodes": [ | ||
| { | ||
| "id": "TGFuZ3VhZ2U6MQ", | ||
| "name": "English " |
Collaborator
There was a problem hiding this comment.
Hva er greien med de lange white-spacene i stringene her?
Collaborator
|
Har du prøvd å fjerne den eksplisitte joinen? Kanskje jOOQ kan ta hånd om det for oss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detects when a filter input creates a LEFT JOIN to a table where the FK originates from the target (one-to-many), removes the LEFT JOIN, and wraps the filter condition in DSL.exists