Filter and weight game constraint templates#23
Open
eiron wants to merge 2 commits intosilasary:keymasters_keepfrom
Open
Filter and weight game constraint templates#23eiron wants to merge 2 commits intosilasary:keymasters_keepfrom
eiron wants to merge 2 commits intosilasary:keymasters_keepfrom
Conversation
Allow for weighted constraints, and also to filter constraints that would make the game time-consuming or difficult.
There was a problem hiding this comment.
Pull request overview
Adds support for filtering and weighting optional game constraint templates so generated trials can avoid difficult/time-consuming constraints unless explicitly allowed.
Changes:
- Introduced
filter_game_constraint_templates()to apply difficult/time-consuming filtering to constraint templates. - Updated objective generation to use the filtered constraint templates.
- Switched optional constraint selection to weighted sampling via
weight.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Introduce a static _filter_templates function to centralize filtering logic for objective/constraint templates and remove duplicated code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for weighted constraints, and also to filter constraints that would make the game time-consuming or difficult.