Conversation
Change-Id: I01a58d2badb9b4d863a91e975499aa49a7d47354
Change-Id: I1ddf2f34733cb72d23b6c705a4dfa653c6b53a12
Change-Id: Ifbc74826caebdae3e0556e5351672f11b38612e5
Change-Id: Ice39b6d3508347f41aface7235940cbd7cdca81c
Change-Id: Id936cb91e838b813b926b5acf18095c7ae295ac7
Change-Id: Ie276229faf998d0ab45c6d3b9f9cfdcd4131fe98
Change-Id: Id7ea53849eab70d91e0dfa43a461c6556aa2856c
Change-Id: Icc7e54b7a50f5d8027c16eaf0efb38186d4965e3
AndyBlack
changed the title
AndyBlack
changed the title
NUnit Tests 1 files ± 0 1 suites ±0 6m 21s ⏱️ +24s For more details on these failures, see this check. Results for commit cd5c5fb. ± Comparison against base commit c450a55. |
papeh
reviewed
Mar 25, 2026
Contributor
papeh
left a comment
papeh
left a comment
There was a problem hiding this comment.
What I've spot-checked from 5 million lines looks good. LGTM when tests are passing.
| // This software is licensed under the LGPL, version 2.1 or later | ||
| // (http://www.gnu.org/licenses/lgpl-2.1.html) | ||
|
|
||
| //using SIL.LcmLoaderUI; |
| { | ||
| return ( | ||
| from fd in FieldDescription.FieldDescriptors(Cache) | ||
| where fd.IsCustomField //&& GetItem(m_locationComboBox, fd.Class) != null |
Contributor
There was a problem hiding this comment.
commented code can be removed
| @@ -0,0 +1,2 @@ | |||
| This folder was taken from https://github.com/sillsdev/pcpatrflex on March 12, 2026. | |||
Contributor
There was a problem hiding this comment.
I think this would make sense to include in README.md so there is only one ReadMe in this folder.
| in a *FieldWorks Language Explorer* project. You tell *Use PC-PATR with FLEx* the PC-PATR grammar file to use. | ||
| Then you can choose a text or a portion of that text and ask *Use PC-PATR with FLEx* to try and disambiguate it. | ||
|
|
||
| While you can use any PC-PATR grammar file, *Use PC-PATR with FLEx* expects that you will have used the *PAWS* program to create he PC-PATR grammar file. See https://software.sil.org/paws/ for more on PAWS. |
Contributor
There was a problem hiding this comment.
...to create the PC-PATR grammar file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for LT-22418 (Move PCPATR with FLEx into the FLEx repo).
This contains three FLEx add-on utilities that have been in production use by a few FLEx users for some time now. The changes here moved what was in the GitHub repository at https://github.com/sillsdev/pcpatrflex/tree/master to Src\Utilities. The utilities are:
Use PcPatr with FLEx: A tool to disambiguate a FLEx text by using a syntactic grammar with PcPatr.
Extract Ana Files from FLEx Texts: A tool to create a CARLA ANA file for a given text in FLEx.
Use TonePars with FLEx: A tool to use the TonePars tool to diambiguate texts in FLEx.
There also is a ReadMe.txt file pointing to the soon-to-be-archived repository mentioned above in case some one needs to check its history.
Note that the code in that repository that is now in FLEx has never undergone a human code review. Since there is so much code, I tried to put each project in its own commit.
This change is