Skip to content

Improve alignment exception error reporting#399

Merged
pmachapman merged 1 commit intomasterfrom
alignment_exceptions
Mar 26, 2026
Merged

Improve alignment exception error reporting#399
pmachapman merged 1 commit intomasterfrom
alignment_exceptions

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Mar 26, 2026

As a part of sillsdev/serval#893, this PR improves error reporting to give details on the ArgumentException that caused the CorpusAlignmentException, and fixes a NullReferenceException when one of the rows referenced in the CorpusAlignmentException is null.


This change is Reviewable

@pmachapman pmachapman requested review from Enkidu93 and ddaspit March 26, 2026 04:11
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.78%. Comparing base (d1390f7) to head (9b3afc7).

Files with missing lines Patch % Lines
src/SIL.Machine/Corpora/NParallelTextCorpus.cs 0.00% 6 Missing ⚠️
...rc/SIL.Machine/Corpora/CorpusAlignmentException.cs 0.00% 4 Missing ⚠️
src/SIL.Machine/Corpora/ParallelTextCorpus.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   72.79%   72.78%   -0.02%     
==========================================
  Files         424      424              
  Lines       36309    36314       +5     
  Branches     5006     5006              
==========================================
  Hits        26431    26431              
- Misses       8770     8775       +5     
  Partials     1108     1108              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ddaspit reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Enkidu93).

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@pmachapman pmachapman merged commit f7ae987 into master Mar 26, 2026
4 checks passed
@pmachapman pmachapman deleted the alignment_exceptions branch March 26, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants