don't install a libtool file with static library #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static library is supported since version 1.3.11 and 2f143c0 However, graphite2 is still installing libgraphite2.la which contains incorrect information (i.e. dlname set to libgraphite2.so and old_library set to ''): dlname='libgraphite2.so' library_names='libgraphite2.so.3.2.1 libgraphite2.so.3 libgraphite2.so' old_library='' dependency_libs='' This will result in the following build failure with any applications using this file such as harfbuzz: arm-linux-g++.br_real: error: /home/buildroot/autobuild/run/instance-3/output-1/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libgraphite2.so: No such file or directory make[5]: *** [main] Error 1 Instead of trying to fix this libtool file, just disable it when building a static library as it is not needed Fixes: - http://autobuild.buildroot.org/results/9ebe1d11e80755d59190ef2aae82bbba5cc45e44 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
applied in #69 |
Contributor
|
It is even less justified to have with |
im not sure what you mean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static library is supported since version 1.3.11 and 2f143c0
However, graphite2 is still installing libgraphite2.la which contains incorrect information (i.e. dlname set to libgraphite2.so and
old_library set to ''):
This will result in the following build failure with any applications using this file such as harfbuzz:
Instead of trying to fix this libtool file, just disable it when building a static library as it is not needed
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com