feat: add Rust API to create requests#6
Merged
jjhafer merged 1 commit intosilvermine:masterfrom Mar 18, 2026
Merged
Conversation
jjhafer
commented
Mar 18, 2026
jjhafer
force-pushed
the
jhafer/improve_rust_api_support
branch
from
a85810c to
cda30cf
Compare
velocitysystems
approved these changes
Mar 18, 2026
| &self, | ||
| request_headers: &Option<HashMap<String, String>>, | ||
| ) -> Result<HeaderMap> { | ||
| let empty = HashMap::new(); |
There was a problem hiding this comment.
Nit: Creates an empty HashMap on every call.
Contributor
Author
There was a problem hiding this comment.
HashMap::new() is effectively free to construct right? Since we're creating it with 0 capacity, no heap allocation occurs until the first insertion. Similar to Vec::new().
Consumers would like to create requests from the Rust side of Tauri apps.
jjhafer
force-pushed
the
jhafer/improve_rust_api_support
branch
from
cda30cf to
894b07e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers would like to create requests from the Rust side of Tauri apps.