fix: infinite loop on user-initiated exit#43
Merged
jjhafer merged 1 commit intosilvermine:masterfrom Mar 10, 2026
Merged
Conversation
pmorris-dev
approved these changes
Mar 5, 2026
jjhafer
approved these changes
Mar 5, 2026
892eaa1 to
f147d05
Compare
velocitysystems
commented
Mar 6, 2026
velocitysystems
commented
Mar 6, 2026
jjhafer
requested changes
Mar 9, 2026
f147d05 to
b0246b2
Compare
jjhafer
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
User-initiated app exit (e.g. closing the window, Cmd+Q) could hang indefinitely. The exit handler called
api.prevent_exit(), ran cleanup, then calledapp_handle.exit()— which re-triggeredExitRequested, creating an infinite loop.Solution
Break the loop by ensuring cleanup only runs once, then letting the programmatic exit through:
ExitRequestedclaims ownership; subsequent ones are skipped.thread::spawn().join().app_handle.exit(0)fires a programmatic exit. The handler recognises programmatic exits by their exit code and lets them pass through without re-running cleanup.prevent_exit()is called to keep the app alive until cleanup completes, but cleanup itself is not restarted.