silx view: Added dark/light mode option; Dependencies: Require PyQt6/PySide6 >=6.5#4487
Open
silx view: Added dark/light mode option; Dependencies: Require PyQt6/PySide6 >=6.5#4487
Conversation
t20100
force-pushed
the
silx-view-color-scheme
branch
from
b01d10d to
de95c5f
Compare
t20100
changed the title
Member
Author
|
Added support for Qt5 and added requirement PyQt and PySide >= 6.5 |
t20100
force-pushed
the
silx-view-color-scheme
branch
from
de95c5f to
833e592
Compare
t20100
commented
Mar 4, 2026
| import PySide6 as QtBinding # noqa | ||
|
|
||
| if Version(QtBinding.__version__) < Version("6.4"): | ||
| if Version(QtBinding.__version__) < Version("6.5"): |
Member
Author
There was a problem hiding this comment.
Enforces QT>=6.5 (April 2023), IMO affordable since we make a major release
Comment on lines
+686
to
+687
| if qt.BINDING == "PyQt5": | ||
| self._colorSchemeMenu.setEnabled(False) |
Member
Author
There was a problem hiding this comment.
Basic way to support Qt5, no longer the main target IMO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<Module or Topic>: <Action> <Summary>(see contributing guidelines)This PR adds a color scheme menu to toggle dark/light mode.