Skip to content

Conversation

@lemire
Copy link
Member

@lemire lemire commented Dec 20, 2025

Short title (summary):

The validate_ascii function is made faster for most kernels

Description

@ChALkeR first raised the issue in nodejs/node#61122

Both validate_ascii and validate_ascii_with_errors are very fast, but when the content is pure ascii, validate_ascii should be faster. This PR fixes the issue.

Type of change

  • Bug fix
  • Optimization
  • New feature
  • Refactor / cleanup
  • Documentation / tests
  • Other (please describe):

@ChALkeR
Copy link

ChALkeR commented Dec 20, 2025

There are also some very weird cases I noticed (not blocking this PR)
Will check later and file a separate issue (or DM me in Slack and I'll demonstrate the weirdness, but I'm not yet sure where it comes from)

@lemire lemire merged commit e93b56c into master Dec 20, 2025
75 checks passed
@lemire
Copy link
Member Author

lemire commented Dec 21, 2025

There are also some very weird cases I noticed (not blocking this PR)

If you have found issues, my preference is that you open a public issue as we are an open community project.

But if you have security issues, I can be reached privately easily by email or you can reach @pauldreik.

@ChALkeR
Copy link

ChALkeR commented Dec 21, 2025

Atm it's just in the "timing seems very strange and needs investigation" stage, filing an issue with that is too early - it lacks data for that yet

It's not a security issue

Given that preference, I'll file this sometime later when I'll get more understanding on what's happening in that specific case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants