Conversation
Contributor
Author
|
@simi Can you take a look pls? |
simi
reviewed
Nov 10, 2025
spec/mongoid/paranoia_spec.rb
Outdated
|
|
||
| before do | ||
| Mongoid.configure do |config| | ||
| config.try(:allow_scopes_to_unset_default_scope=, true) |
Owner
There was a problem hiding this comment.
Why try? Possible to also store original value and set back after the test?
simi
reviewed
Nov 10, 2025
spec/mongoid/paranoia_spec.rb
Outdated
| it "returns the deleted documents" do | ||
| expect(with_deleted).to eq(posts) | ||
| end | ||
| end if respond_to?(:allow_scopes_to_unset_default_scope=) |
Owner
There was a problem hiding this comment.
Should it ask Mongoid.respond_to? 🤔?
Contributor
Author
|
@simi Made changes as per your suggestions. |
Contributor
Author
|
@simi ping 🙂 |
Owner
|
👀 |
Owner
|
Thanks a lot! |
Contributor
Author
|
Great, thanks! Hoping for a release soon 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
with_deletedscope as discussed in #75Not sure if the feature guards in specs are okay like this.
Also, another option for the scope definition is to completely wrap it in the conditional instead of raising inside.